Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiserver glog uses -alsologtostderr #859

Merged
merged 1 commit into from
Mar 1, 2019
Merged

apiserver glog uses -alsologtostderr #859

merged 1 commit into from
Mar 1, 2019

Conversation

ywskycn
Copy link
Member

@ywskycn ywskycn commented Feb 25, 2019

To make "kubectl logs" work for apiserver, instead of sshing into the apiserver pod.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @ywskycn. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @ywskycn. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan
Copy link
Member

IronPan commented Feb 27, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ywskycn
Copy link
Member Author

ywskycn commented Mar 1, 2019

It looks like the e2e-test is unrelated. @IronPan anyway to re-trigger the test?

@IronPan
Copy link
Member

IronPan commented Mar 1, 2019

/test kubeflow-pipeline-e2e-test

@IronPan
Copy link
Member

IronPan commented Mar 1, 2019

/test kubeflow-pipeline-e2e-test will retrigger the test

@k8s-ci-robot k8s-ci-robot merged commit de9a982 into kubeflow:master Mar 1, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants