Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to take test status into account when reporting prow job success or failure #27

Closed
jlewi opened this issue Feb 12, 2018 · 0 comments
Closed

Need to take test status into account when reporting prow job success or failure #27

jlewi opened this issue Feb 12, 2018 · 0 comments
Assignees
@jlewi

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 12, 2018

We need to look at the junit XML files to decide whether to report the job as failed or success

  • Right now we just look at whether the Argo workflow succeeded or not which is insufficient since tests can fail but Argo workflow can still succeed.

We need to do something like kubeflow/training-operator#319

If we want to be strict about which xml files are expected we could specify the xml files expected in the prow_config.yaml file.
@jlewi jlewi mentioned this issue Feb 21, 2018
Merged
@jlewi jlewi self-assigned this Feb 21, 2018
jlewi added a commit to jlewi/testing that referenced this issue Feb 21, 2018
@jlewi
Taking junit results into account when computing prow job status.
72b43af 
* When decided whether to mark a prow job as failed or succeded we need
  to explicitly look at the junit files and determine that.

* Prow won't do this automatically.

* Fix kubeflow#27
@jlewi jlewi mentioned this issue Feb 21, 2018
Merged
@jlewi jlewi closed this as completed in #38 Feb 22, 2018
jlewi added a commit that referenced this issue Feb 22, 2018
@jlewi
Taking junit results into account when computing prow job status. (#38)
be7d554 
When decided whether to mark a prow job as failed or succeded we need
to explicitly look at the junit files and determine that.

Prow won't do this automatically.

Fix #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlewi jlewi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlewi