Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label sync cron job and add back label which has external dependency #104

Merged
merged 6 commits into from
Apr 10, 2018
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions label_sync/cluster/label_sync_job.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
apiVersion: batch/v1beta1
kind: CronJob
metadata:
name: label-sync-fix
spec:
schedule: "17 23 * * *" # Every day 23:17 / 11:17PM
concurrencyPolicy: Forbid
jobTemplate:
metadata:
labels:
app: label-sync
spec:
template:
spec:
containers:
- name: label-sync
image: gcr.io/k8s-testimages/label_sync:v20180227-377685119
args:
- --config=/etc/config/kubeflow_label.yml
- --confirm=true
- --orgs=kubeflow
- --token=/etc/github/bot-token
- --skip=kubeflow/kubeflow,kubeflow/tf-operator,kubeflow/testing,kubeflow/example-seldon,kubeflow/experimental-kvc
volumeMounts:
- name: oauth
mountPath: /etc/github
readOnly: true
- name: config
mountPath: /etc/config
readOnly: true
restartPolicy: Never
volumes:
- name: oauth
secret:
secretName: bot-token-github
- name: config
configMap:
name: label-config-v2
4 changes: 2 additions & 2 deletions label_sync/kubeflow_label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ labels:
name: status/icebox
- color: ffa500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the status/approved label to approved and also add label lgtm? Those labels are used by the k8s-ci-bot. So status/approved is duplicative. I think by adding them here we can ensure consistent colors.

name: status/in progress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove in progress since we have /work-in progress?

previously:
- name: do-not-merge/work-in-progress
- color: ffa500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment about this being used by prow so not remove it.

name: do-not-merge/work-in-progress
- color: 2efca4
name: status/lgtm
- color: 00daff
Expand Down