-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label sync cron job and add back label which has external dependency #104
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c5cb6cf
add kubeflow_label.yml for label sycn across repos in kubeflow, along…
kunmingg 2a0f03a
reformat process_label.py to fix pylint check
kunmingg 39ab27f
handle code review feedback & change code to python3
kunmingg 24873c8
Merge remote-tracking branch 'upstream/master'
kunmingg f2ea8b3
cron job config for label sync, along with adding 'do-not-merge' back
kunmingg cd4421e
handle review feedback
kunmingg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
apiVersion: batch/v1beta1 | ||
kind: CronJob | ||
metadata: | ||
name: label-sync-fix | ||
spec: | ||
schedule: "17 23 * * *" # Every day 23:17 / 11:17PM | ||
concurrencyPolicy: Forbid | ||
jobTemplate: | ||
metadata: | ||
labels: | ||
app: label-sync | ||
spec: | ||
template: | ||
spec: | ||
containers: | ||
- name: label-sync | ||
image: gcr.io/k8s-testimages/label_sync:v20180227-377685119 | ||
args: | ||
- --config=/etc/config/kubeflow_label.yml | ||
- --confirm=true | ||
- --orgs=kubeflow | ||
- --token=/etc/github/bot-token | ||
- --skip=kubeflow/kubeflow,kubeflow/tf-operator,kubeflow/testing,kubeflow/example-seldon,kubeflow/experimental-kvc | ||
volumeMounts: | ||
- name: oauth | ||
mountPath: /etc/github | ||
readOnly: true | ||
- name: config | ||
mountPath: /etc/config | ||
readOnly: true | ||
restartPolicy: Never | ||
volumes: | ||
- name: oauth | ||
secret: | ||
secretName: bot-token-github | ||
- name: config | ||
configMap: | ||
name: label-config-v2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,8 +102,8 @@ labels: | |
name: status/icebox | ||
- color: ffa500 | ||
name: status/in progress | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we remove in progress since we have /work-in progress? |
||
previously: | ||
- name: do-not-merge/work-in-progress | ||
- color: ffa500 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a comment about this being used by prow so not remove it. |
||
name: do-not-merge/work-in-progress | ||
- color: 2efca4 | ||
name: status/lgtm | ||
- color: 00daff | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change the status/approved label to approved and also add label lgtm? Those labels are used by the k8s-ci-bot. So status/approved is duplicative. I think by adding them here we can ensure consistent colors.