-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label sync cron job and add back label which has external dependency #104
Conversation
… with helper script to generate it.
/assign @DjangoPeng |
label_sync/kubeflow_label.yml
Outdated
@@ -102,8 +102,8 @@ labels: | |||
name: status/icebox | |||
- color: ffa500 | |||
name: status/in progress | |||
previously: | |||
- name: do-not-merge/work-in-progress | |||
- color: ffa500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment about this being used by prow so not remove it.
label_sync/kubeflow_label.yml
Outdated
@@ -102,8 +102,8 @@ labels: | |||
name: status/icebox | |||
- color: ffa500 | |||
name: status/in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove in progress since we have /work-in progress?
label_sync/kubeflow_label.yml
Outdated
@@ -102,8 +102,8 @@ labels: | |||
name: status/icebox | |||
- color: ffa500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change the status/approved label to approved and also add label lgtm? Those labels are used by the k8s-ci-bot. So status/approved is duplicative. I think by adding them here we can ensure consistent colors.
Can you also add label: "area/usage" for issues related to reporting and metrics. |
@jlewi config updated and tested.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add config for label_sync cron job, and add "do-not-merge/work-in-progress" back to fix prow merge.
Details see: #102