Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label sync cron job and add back label which has external dependency #104

Merged
merged 6 commits into from
Apr 10, 2018

Conversation

kunmingg
Copy link
Contributor

@kunmingg kunmingg commented Apr 9, 2018

Add config for label_sync cron job, and add "do-not-merge/work-in-progress" back to fix prow merge.
Details see: #102

@kunmingg kunmingg changed the title Merge label Add label sync cron job and add back label which has external dependency Apr 10, 2018
@kunmingg
Copy link
Contributor Author

/assign @DjangoPeng

@@ -102,8 +102,8 @@ labels:
name: status/icebox
- color: ffa500
name: status/in progress
previously:
- name: do-not-merge/work-in-progress
- color: ffa500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment about this being used by prow so not remove it.

@@ -102,8 +102,8 @@ labels:
name: status/icebox
- color: ffa500
name: status/in progress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove in progress since we have /work-in progress?

@@ -102,8 +102,8 @@ labels:
name: status/icebox
- color: ffa500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the status/approved label to approved and also add label lgtm? Those labels are used by the k8s-ci-bot. So status/approved is duplicative. I think by adding them here we can ensure consistent colors.

@jlewi
Copy link
Contributor

jlewi commented Apr 10, 2018

Can you also add label: "area/usage" for issues related to reporting and metrics.

@kunmingg
Copy link
Contributor Author

@jlewi config updated and tested.
Sample action on "kubeflow/community":

time="2018-04-10T10:38:25-07:00" level=info msg=migrate from="status/approved" repo=community to=approved
time="2018-04-10T10:38:25-07:00" level=info msg=migrate from="status/in progress" repo=community to="do-not-merge/work-in-progress"
time="2018-04-10T10:38:25-07:00" level=info msg=migrate from="status/lgtm" repo=community to=lgtm
time="2018-04-10T10:38:25-07:00" level=info msg=recolor color=2efca4 label=lgtm repo=community
time="2018-04-10T10:38:25-07:00" level=info msg=create label="area/usage" repo=community
time="2018-04-10T10:38:25-07:00" level=info msg=recolor color=03db12 label=approved repo=community

@jlewi
Copy link
Contributor

jlewi commented Apr 10, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants