Support subdirectories for junit files and junit_class_name #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @zhenghuiwang |
|
/test all |
* We want to support putting junit files in subdirectories e.g.
junit/junit_workflow1/junit_test1.xml
junit/junit_workflow2/junit_test1.xml
* prow_artifacts.py needs to fetch the junit files from GCS in order to
determine if there were any test failures to properly set the prow job
status
* The code however was making an assumption that all results were in
the artifacts dir and not subdirectories
* run_e2e_workflow.py should set a keyword argument test_target_name
to the name of the workflow (as set in prow_config.yaml) for each of
the python functions creating argo workflows.
* We want to use the junit attribute classname to group tests coming
from the same workflow. To do that we need to know the name of the workflow.
* We also use this as a prefix for the test name to support grouping
hierarchically
* Related to kubeflow#489
* Update kfunittests to Use a junit subdirectory to make sure subdirectories are properly handled.
* Update docs
* update toc.
* Convert test_py_lint to use pytest. Do this because we want to be able to test the use of junit features.
* Add a separate mkdir step.
|
On the latest run the name for the pylint test was So overriding the test name in the junit appears to work. No results are showing up in the test grid at all so I can't verify that's working. That seems unrelated to this PR. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhenghuiwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
Oct 18, 2019
…rid by name (kubeflow#490)" This reverts commit 16ea186. The commit breaks kfctl_e2e_workflow.py tests because we introduced an extra argument.
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
Oct 18, 2019
…n test grid by name (kubeflow#490)" (kubeflow#493)" This reverts commit 81326be. * Relates to kubeflow#489 * Roll forward the orginal change now that kfctl_create_e2e_workflow.py has been updated.
jlewi
pushed a commit
to jlewi/testing
that referenced
this pull request
Oct 18, 2019
…n test grid by name (kubeflow#490)" (kubeflow#493)" This reverts commit 81326be. * Relates to kubeflow#489 * Roll forward the orginal change now that kfctl_create_e2e_workflow.py has been updated to handle the extra argument. add a leading /
jlewi
pushed a commit
to jlewi/kubeflow
that referenced
this pull request
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support subdirectories for junit files and grouping in test grid by name
We want to support putting junit files in subdirectories e.g.
junit/junit_workflow1/junit_test1.xml
junit/junit_workflow2/junit_test1.xml
prow_artifacts.py needs to fetch the junit files from GCS in order to
determine if there were any test failures to properly set the prow job
status
The code however was making an assumption that all results were in
the artifacts dir and not subdirectories
run_e2e_workflow.py should set a keyword argument test_target_name
to the name of the workflow (as set in prow_config.yaml) for each of
the python functions creating argo workflows.
We want to use the junit attribute classname to group tests coming
from the same workflow. To do that we need to know the name of the workflow.
We also use this as a prefix for the test name to support grouping
hierarchically
Related to Support grouping in testgrid #489
Update kfunittests to Use a junit subdirectory to make sure subdirectories are properly handled.
Update docs
update toc.
Convert test_py_lint to use pytest. Do this because we want to be able to test the use of junit features.
Add a separate mkdir step.
This change is