Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subdirectories for junit files and junit_class_name #490

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Support subdirectories for junit files and junit_class_name #490

merged 1 commit into from
Oct 17, 2019

Commits on Oct 17, 2019

  1. Support subdirectories for junit files and grouping in test grid by name 

    * We want to support putting junit files in subdirectories e.g.
  junit/junit_workflow1/junit_test1.xml
  junit/junit_workflow2/junit_test1.xml

  * prow_artifacts.py needs to fetch the junit files from GCS in order to
    determine if there were any test failures to properly set the prow job
    status

  * The code however was making an assumption that all results were in
    the artifacts dir and not subdirectories

* run_e2e_workflow.py should set a keyword argument test_target_name
  to the name of the workflow (as set in prow_config.yaml) for each of
  the python functions creating argo workflows.

  * We want to use the junit attribute classname to group tests coming
    from the same workflow. To do that we need to know the name of the workflow.

  * We also use this as a prefix for the test name to support grouping
    hierarchically

* Related to kubeflow#489

* Update kfunittests to Use a junit subdirectory to make sure subdirectories are properly handled.

* Update docs

* update toc.

* Convert test_py_lint to use pytest. Do this because we want to be able to test the use of junit features.

* Add a separate mkdir step.
    Jeremy Lewi committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    f9589ed View commit details
    Browse the repository at this point in the history