Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename top level python package - py -> kubeflow-tf-job #914

Closed
jlewi opened this issue Jan 15, 2019 · 12 comments · Fixed by kubeflow/testing#322
Closed

Rename top level python package - py -> kubeflow-tf-job #914

jlewi opened this issue Jan 15, 2019 · 12 comments · Fixed by kubeflow/testing#322
Assignees

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 15, 2019

The top level package for our python code is currently "py".

This is rather generic; unfortunately it conflicts with https://docs.pytest.org

If we can make namespace packaging working then we could follow the convention of having each repo be imported as

import kubeflow.{REPO_NAME}

Alternative would be to just rename the top level package to something like kf-tfjob.

@jlewi
Copy link
Contributor Author

jlewi commented Jan 15, 2019

Renaming the package would likely require upgrading the E2E tests that are checking out kubeflow/tf-operator as an extra-repo. We might want to pin those tests to a particular commit so they don't all get broken.

@richardsliu richardsliu self-assigned this Feb 12, 2019
@richardsliu
Copy link
Contributor

/assign @Zahraabbasi

@k8s-ci-robot
Copy link

@richardsliu: GitHub didn't allow me to assign the following users: zahraabbasi.

Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Zahraabbasi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardsliu
Copy link
Contributor

/assign @zabbasi

@k8s-ci-robot
Copy link

@richardsliu: GitHub didn't allow me to assign the following users: zabbasi.

Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @zabbasi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardsliu
Copy link
Contributor

/assign @zabbasi

@k8s-ci-robot
Copy link

@richardsliu: GitHub didn't allow me to assign the following users: zabbasi.

Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @zabbasi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zabbasi
Copy link
Contributor

zabbasi commented Feb 12, 2019

/assign @zabbasi

@k8s-ci-robot
Copy link

@zabbasi: GitHub didn't allow me to assign the following users: zabbasi.

Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @zabbasi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardsliu richardsliu assigned zabbasi and unassigned richardsliu Feb 21, 2019
@zabbasi
Copy link
Contributor

zabbasi commented Feb 21, 2019

/assign @zabbasi

k8s-ci-robot pushed a commit that referenced this issue Feb 27, 2019
* renamed top level python package

* removed redundant folder

* applied package renaming in  workflows

* removed name in init file

* added path tf-operator/py to PYTHONPATH

* adding py to PYTHONPATH

* fixed a typo

* fixed moudle updated name in few tests
@zabbasi
Copy link
Contributor

zabbasi commented Mar 4, 2019

/close

@zabbasi
Copy link
Contributor

zabbasi commented Mar 4, 2019

addressed in #945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants