-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename top level python package - py -> kubeflow-tf-job #914
Comments
Renaming the package would likely require upgrading the E2E tests that are checking out kubeflow/tf-operator as an extra-repo. We might want to pin those tests to a particular commit so they don't all get broken. |
/assign @Zahraabbasi |
@richardsliu: GitHub didn't allow me to assign the following users: zahraabbasi. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @zabbasi |
@richardsliu: GitHub didn't allow me to assign the following users: zabbasi. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @zabbasi |
@richardsliu: GitHub didn't allow me to assign the following users: zabbasi. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @zabbasi |
@zabbasi: GitHub didn't allow me to assign the following users: zabbasi. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @zabbasi |
* renamed top level python package * removed redundant folder * applied package renaming in workflows * removed name in init file * added path tf-operator/py to PYTHONPATH * adding py to PYTHONPATH * fixed a typo * fixed moudle updated name in few tests
/close |
addressed in #945 |
The top level package for our python code is currently "py".
This is rather generic; unfortunately it conflicts with https://docs.pytest.org
If we can make namespace packaging working then we could follow the convention of having each repo be imported as
Alternative would be to just rename the top level package to something like
kf-tfjob
.The text was updated successfully, but these errors were encountered: