Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the typo #1178

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Fix the typo #1178

merged 1 commit into from
Aug 12, 2020

Conversation

pingsutw
Copy link
Member

Fix the typo in pkg/controller.v1/tensorflow/tensorflow.go

@kubeflow-bot
Copy link

This change is Reviewable

@coveralls
Copy link

coveralls commented Jun 27, 2020

Coverage Status

Coverage remained the same at 96.667% when pulling f5c428d on pingsutw:typo into e0ef86b on kubeflow:master.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@jinchihe
Copy link
Member

jinchihe commented Jun 28, 2020

Seems the pylint check failed for the examples/v1/distribution_strategy/keras-API/multi_worker_strategy-with-keras.py. That's strange, why passed the check when introduced the file in PR #1164 ?

We need to enhance the file to pass the pylint check or ignore that.

@jinchihe
Copy link
Member

That's strange, why passed the check when introduced the file in PR #1164 ?

That's caused by the examples/ dir does not trigger the presubmit tests, and pylint covered all path of the projects. so the presubmit test is triggered by the PR change, and pylint failed due to a python script under examples/

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

@k8s-ci-robot k8s-ci-robot merged commit da22601 into kubeflow:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants