Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update func name to pastBackoffLimit in comment #979

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Update func name to pastBackoffLimit in comment #979

merged 1 commit into from
Apr 29, 2019

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Apr 23, 2019 •
edited by jlewi
Loading

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling ae7e06b on terrytangyuan:patch-1 into ef0e0a4 on kubeflow:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling ae7e06b on terrytangyuan:patch-1 into ef0e0a4 on kubeflow:master.

@terrytangyuan
Copy link
Member Author

/retest

@ChanYiLin
Copy link
Member

/lgtm
Thanks for the fix, I didn't notice that :)

gaocegege
gaocegege reviewed Apr 29, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 47e5d0e into kubeflow:master Apr 29, 2019
@terrytangyuan terrytangyuan deleted the patch-1 branch April 29, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@codeflitting codeflitting Awaiting requested review from codeflitting

@willb willb Awaiting requested review from willb

Assignees

@ChanYiLin ChanYiLin

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@terrytangyuan @coveralls @ChanYiLin @k8s-ci-robot @gaocegege