Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new scheduler-plugins API group #1769

Closed
tenzen-y opened this issue Mar 3, 2023 · 6 comments · Fixed by #1824
Closed

Support new scheduler-plugins API group #1769

tenzen-y opened this issue Mar 3, 2023 · 6 comments · Fixed by #1824

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Mar 3, 2023

Since kubernetes-sigs/scheduler-plugins#526, the scheduler-plugins switch the API group to x-k8s.io.
So we need to support both API groups to keep backward compatibility since we are using an old API group, sigs.k8s.io.

/kind feature

@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 3, 2023

With more investigation, it is hard to keep backward compatibility since the scheduler-plugins fully replaced the sigs.k8s.io with the x-k8s.io.

Maybe, we need to stop supporting v0.24.x or lower scheduler-plugins.

@johnugeorge, Can you add a notice that we will stop supporting older scheduler-plugins v0.24.x or lower in the next training-operator version (v1.7.0) to our release note for v1.6.0?

@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 3, 2023

ref: kubeflow/mpi-operator#500

@johnugeorge
Copy link
Member

Makes sense. It is hard and I think, it is ok. Added the note to the release

@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 6, 2023

Makes sense. It is hard and I think, it is ok. Added the note to the release

Thanks!

@tenzen-y
Copy link
Member Author

tenzen-y commented May 7, 2023

/assign

@tenzen-y
Copy link
Member Author

I will work on this after #1714 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants