Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ BREAKING CHANGE: switch API group to x-k8s.io #526

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

Huang-Wei
Copy link
Contributor

What type of PR is this?

/kind api-change

What this PR does / why we need it:

It's requested to document all usages of "k8s.io" and "kubernetes.io" in k/website. However, scheduler-plugins is not supposed to be part of upstream.

To comply with https://kubernetes.io/docs/reference/labels-annotations-taints/, we should stop using "k8s.io" and "kubernetes.io" in all places of this repo, including:

  • API group
  • Labels
  • Annotations

Which issue(s) this PR fixes:

Fixes #525

Special notes for your reviewer:

Does this PR introduce a user-facing change?

ACTION REQUIRED:
- The CRDs `PodGroup` and `ElasticQuota` are now using a new API group: `scheduling.x-k8s.io`. When you upgrade scheduler-plugins to version v0.25.x, run `kubectl replace -f <crd yamls>` to register the new CRDs.
- The Pods work with `PodGroup` feature need to migrate to use new label: `scheduling.x-k8s.io/pod-group`.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Huang-Wei Huang-Wei added this to the v1.25 milestone Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2023
@Huang-Wei
Copy link
Contributor Author

/assign @denkensk

@denkensk
Copy link
Member

/lgtm

Thanks @Huang-Wei

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 440fd4e into kubernetes-sigs:master Feb 28, 2023
@Huang-Wei Huang-Wei deleted the break/x-k8s.io branch February 28, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing all *.k8s.io labels/annotations to *.x-k8s.io
3 participants