Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the scheduler-plugins version #1773

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I pinned the scheduler-plugins version to fix CI errors.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Ref #1769

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

coveralls commented Mar 13, 2023

Pull Request Test Coverage Report for Build 4402988623

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 39.368%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 76.79%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 58.19%
Totals Coverage Status
Change from base Build 4206779468: 0.01%
Covered Lines: 2727
Relevant Lines: 6927

💛 - Coveralls

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d46247c into kubeflow:master Mar 13, 2023
@tenzen-y tenzen-y deleted the fix-ci branch March 13, 2023 12:41
tenzen-y added a commit to tenzen-y/training-operator that referenced this pull request Mar 21, 2023
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y added a commit to tenzen-y/training-operator that referenced this pull request Mar 21, 2023
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
google-oss-prow bot pushed a commit that referenced this pull request Mar 21, 2023
)

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants