Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage Pods directly instead of using Job controllers #325

Closed
jlewi opened this issue Jan 18, 2018 · 7 comments
Closed

Manage Pods directly instead of using Job controllers #325

jlewi opened this issue Jan 18, 2018 · 7 comments
Assignees
@ScorpioCPH
Labels
difficulty/medium kind/enhancement priority/p1
Milestone
Kubecon Europe

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 18, 2018

Consensus in #45 was that we should manage the pods directly. Opening this issue to track that work.
This was referenced Jan 18, 2018
Closed
Closed
@ScorpioCPH
Copy link
Member

Hi, folks, I will pick up this if nobody working on this :)

@jlewi
Copy link
Contributor Author

jlewi commented Jan 19, 2018

that would be great!

@gaocegege
Copy link
Member

@ScorpioCPH

Awesome! And I think it is hard to decouple #314 and this issue 🤔 Would you file one PR for these two issues together?

@jlewi jlewi mentioned this issue Jan 20, 2018
Closed
@ScorpioCPH ScorpioCPH mentioned this issue Jan 24, 2018
Merged
@jlewi jlewi added this to the Kubecon Europe milestone Jan 25, 2018
@vishh
Copy link

vishh commented Feb 15, 2018

Just FYI: @kow3ns and I have been noodling on the idea of a stateful Job that would benefit TF Training Operator. Managing pods outside of existing curated controllers is a risky proposition IMHO, but might be a good stop gap solution.
We will post some updates once we get around to having some concrete designs on that.

@gaocegege
Copy link
Member

@vishh We can discuss it in the issue #45

jlewi pushed a commit that referenced this issue Mar 5, 2018
@ScorpioCPH @jlewi
Create pod instead of job (#344)
6706903 
This PR is a part of #325:

rename jobName() to genName()
create Pod instead of Job

TODOs (in another PR):

use controller.PodControlInterface and CreatePodsWithControllerRef to create Pod
Listen Pod CRUD and update TFJob status which descried in #314
jimexist pushed a commit to jimexist/tf-operator that referenced this issue Mar 7, 2018
@ScorpioCPH
Create pod instead of job (kubeflow#344)
de82ac0 
This PR is a part of kubeflow#325:

rename jobName() to genName()
create Pod instead of Job

TODOs (in another PR):

use controller.PodControlInterface and CreatePodsWithControllerRef to create Pod
Listen Pod CRUD and update TFJob status which descried in kubeflow#314
@jlewi
Copy link
Contributor Author

jlewi commented Mar 7, 2018

@ScorpioCPH #344 is merged. Can we close this? Or is there more work to be done?

@ScorpioCPH
Copy link
Member

/close

@llhuii llhuii mentioned this issue Mar 17, 2021
Open
@gaocegege gaocegege mentioned this issue Jul 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScorpioCPH ScorpioCPH

Labels
difficulty/medium kind/enhancement priority/p1
Projects
None yet
Milestone
Kubecon Europe
Development

No branches or pull requests
6 participants
@jlewi @gaocegege @ScorpioCPH @vishh @DjangoPeng @k8s-ci-robot