Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mpi doc #1477

Merged
merged 1 commit into from
Nov 22, 2021
Merged

add mpi doc #1477

merged 1 commit into from
Nov 22, 2021

Conversation

zw0610
Copy link
Member

@zw0610 zw0610 commented Nov 22, 2021

While the mpijob api and controller are merged, the document is still missing.

  • add auto-generate script for mpijob
  • add mpijob doc
  • update readme

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1488568458

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 24.099%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 75.31%
Totals Coverage Status
Change from base Build 1486793318: -0.04%
Covered Lines: 1197
Relevant Lines: 4967
💛 - Coveralls

gaocegege
gaocegege reviewed Nov 22, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 22, 2021
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, zw0610

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8f4e031 into kubeflow:master Nov 22, 2021
@terrytangyuan terrytangyuan mentioned this pull request Nov 22, 2021
Merged
@zw0610 zw0610 deleted the mpi-api-doc branch June 20, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zw0610 @coveralls @gaocegege