Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MPI job to README now that it's supported #1480

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Add MPI job to README now that it's supported #1480

merged 1 commit into from
Nov 23, 2021

Conversation

terrytangyuan
Copy link
Member

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1491001639

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 24.059%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 75.12%
Totals Coverage Status
Change from base Build 1488691981: 0.0%
Covered Lines: 1195
Relevant Lines: 4967
💛 - Coveralls

gaocegege
gaocegege reviewed Nov 23, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@google-oss-prow google-oss-prow bot added the lgtm label Nov 23, 2021
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gaocegege,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 15712aa into master Nov 23, 2021
@terrytangyuan terrytangyuan deleted the terrytangyuan-patch-2 branch November 23, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terrytangyuan @coveralls @gaocegege