Set the default value of CleanPodPolicy to None #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4131438052
💛 - Coveralls |
Syulin7
force-pushed
the
fix_cleanpodpolicy
branch
2 times, most recently
from
8dd210f
to
af9209a
Compare
tenzen-y
reviewed
Feb 9, 2023
Comment on lines
63
to
64
| c := cleanPodPolicy | ||
| return &c |
There was a problem hiding this comment.
Suggested change
| c := cleanPodPolicy | |
| return &c | |
| return &cleanPodPolicy |
Signed-off-by: Syulin7 <735122171@qq.com>
Syulin7
force-pushed
the
fix_cleanpodpolicy
branch
from
af9209a
to
4398c32
Compare
tenzen-y
reviewed
Feb 9, 2023
|
/approve Thanks @Syulin7 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, Syulin7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
* Add validation for verifying that the CustomJob (e.g., TFJob) name meets DNS1035 (#1748) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Fix the success condition of the job in PyTorchJob's Elastic mode. (#1752) Signed-off-by: Syulin7 <735122171@qq.com> * Set the default value of CleanPodPolicy to None (#1754) Signed-off-by: Syulin7 <735122171@qq.com> * Update mpijob_controller.go (#1755) fix typo TFJob, should be MPIJob --------- Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Syulin7 <735122171@qq.com> Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Co-authored-by: yu lin <37265556+Syulin7@users.noreply.github.com> Co-authored-by: Yasser Shalabi <yassershalabi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Set the default value of CleanPodPolicy to None.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #1753
Checklist: