Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick commits #1757

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Cherry pick commits #1757

merged 4 commits into from
Feb 13, 2023

Conversation

johnugeorge
Copy link
Member

Cherry pick commits from master to release 1.6 branch

/hold

tenzen-y and others added 4 commits February 1, 2023 16:52
…ets DNS1035 (#1748)

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Syulin7 <735122171@qq.com>
fix typo TFJob, should be MPIJob
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@coveralls
Copy link

coveralls commented Feb 13, 2023

Pull Request Test Coverage Report for Build 4166191666

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.4%) to 39.356%

Files with Coverage Reduction New Missed Lines %
pkg/apis/kubeflow.org/v1/mxnet_validation.go 2 95.0%
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 3 53.35%
pkg/apis/kubeflow.org/v1/pytorch_validation.go 4 90.91%
pkg/apis/kubeflow.org/v1/xgboost_validation.go 4 91.84%
pkg/apis/kubeflow.org/v1/tensorflow_validation.go 12 75.0%
pkg/controller.v1/pytorch/pytorchjob_controller.go 25 58.19%
Totals Coverage Status
Change from base Build 4015610097: 0.4%
Covered Lines: 2725
Relevant Lines: 6924

💛 - Coveralls

@johnugeorge
Copy link
Member Author

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 5a5f92d into v1.6-branch Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants