-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerize e2e tests for training operator conformance #1780
Containerize e2e tests for training operator conformance #1780
Conversation
Pull Request Test Coverage Report for Build 4461944776
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nagar-ajay Thank you for creating this PR!
Created docker container using Dockerfile.conformance file, ran it on a Kubernetes cluster and verified the test logs.
Can you include that manifest in the training operator repo as with https://github.com/kubeflow/kubeflow/blob/edd87a489ad092d9fafd1658b5bd704b72633ebc/conformance/1.5/kfp-conformance.yaml?
Yes, I'll add that. That PR will also include changes to |
Does that mean you will add manifests in another PR? |
Yes, I'll create another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nagar-ajay Thanks!
/lgtm
/assign @johnugeorge
Great work @nagar-ajay /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, nagar-ajay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Dockerfile.conformance
docker file to build container which contains test required for conformance.publish-conformance-images.yaml
github action to publish conformance test docker image as part of CI.resources
parameter to each container as it is required if the containers running in the namespace haveresourceQuotaSpec
specified. For conformance namespace, we're specifyingresourceQuotaSpec
https://github.com/kubeflow/kubeflow/blob/master/conformance/1.5/setup.yaml#L24-L28
Dockerfile.conformance
file, ran it on a Kubernetes cluster and verified the test logs.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: