Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerize e2e tests for training operator conformance #1780

Merged
merged 11 commits into from
Mar 19, 2023

Conversation

nagar-ajay
Copy link
Contributor

@nagar-ajay nagar-ajay commented Mar 16, 2023

What this PR does / why we need it:

  • This PR contains the changes required for training operator conformance test.
  • Added Dockerfile.conformance docker file to build container which contains test required for conformance.
  • Added publish-conformance-images.yaml github action to publish conformance test docker image as part of CI.
  • pass resources parameter to each container as it is required if the containers running in the namespace have resourceQuotaSpec specified. For conformance namespace, we're specifying resourceQuotaSpec
    https://github.com/kubeflow/kubeflow/blob/master/conformance/1.5/setup.yaml#L24-L28
  • Testing:
    • Tested updated test on local.
    • Created docker container using Dockerfile.conformance file, ran it on a Kubernetes cluster and verified the test logs.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Mar 16, 2023

Pull Request Test Coverage Report for Build 4461944776

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 39.411%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 76.79%
Totals Coverage Status
Change from base Build 4434655960: 0.0%
Covered Lines: 2730
Relevant Lines: 6927

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nagar-ajay Thank you for creating this PR!

Created docker container using Dockerfile.conformance file, ran it on a Kubernetes cluster and verified the test logs.

Can you include that manifest in the training operator repo as with https://github.com/kubeflow/kubeflow/blob/edd87a489ad092d9fafd1658b5bd704b72633ebc/conformance/1.5/kfp-conformance.yaml?

sdk/python/Dockerfile.conformance Show resolved Hide resolved
sdk/python/Dockerfile.conformance Outdated Show resolved Hide resolved
@nagar-ajay nagar-ajay changed the title Containerize e2e tests for training operator conformance [WIP] - Containerize e2e tests for training operator conformance Mar 18, 2023
@nagar-ajay nagar-ajay changed the title [WIP] - Containerize e2e tests for training operator conformance Containerize e2e tests for training operator conformance Mar 19, 2023
@nagar-ajay
Copy link
Contributor Author

Can you include that manifest in the training operator repo as with https://github.com/kubeflow/kubeflow/blob/edd87a489ad092d9fafd1658b5bd704b72633ebc/conformance/1.5/kfp-conformance.yaml?

Yes, I'll add that. That PR will also include changes to Makefile.

sdk/python/Dockerfile.conformance Outdated Show resolved Hide resolved
sdk/python/conformance/run.sh Show resolved Hide resolved
sdk/python/test/e2e/test_e2e_mpijob.py Outdated Show resolved Hide resolved
sdk/python/test/e2e/test_e2e_mpijob.py Outdated Show resolved Hide resolved
sdk/python/test/e2e/test_e2e_mxjob.py Outdated Show resolved Hide resolved
sdk/python/test/e2e/test_e2e_paddlejob.py Outdated Show resolved Hide resolved
sdk/python/test/e2e/test_e2e_pytorchjob.py Outdated Show resolved Hide resolved
sdk/python/test/e2e/test_e2e_tfjob.py Outdated Show resolved Hide resolved
sdk/python/test/e2e/test_e2e_xgboostjob.py Outdated Show resolved Hide resolved
sdk/python/test/e2e/test_e2e_xgboostjob.py Outdated Show resolved Hide resolved
@tenzen-y
Copy link
Member

Yes, I'll add that. That PR will also include changes to Makefile.

Does that mean you will add manifests in another PR?
If so, I'm ok.

@nagar-ajay
Copy link
Contributor Author

Does that mean you will add manifests in another PR? If so, I'm ok.

Yes, I'll create another PR.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nagar-ajay Thanks!
/lgtm
/assign @johnugeorge

@johnugeorge
Copy link
Member

Great work @nagar-ajay

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, nagar-ajay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4767711 into kubeflow:master Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants