Support testing on minikube. #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When using minikube we don't want call configure_kubectl which calls gcloud container clusters get-credentials. * Instead we just need to call load_kube_config to load the kube config file. * Related to kubeflow/testing#6
|
/lgtm |
|
/approve |
|
/retest |
|
Hi Jeremy, I pushed a patch to fix code linting problems in the code #498 , I think you could rebase and run the test again. |
gaocegege
reviewed
Mar 23, 2018
py/test_runner.py
Outdated
| # as part of GKE cluster creation and store the config in the NFS directory. | ||
| # This would make the handling of credentials | ||
| # and KUBECONFIG more consistent between GKE and minikube and eventually | ||
| # this could be extended to other K8s deployments. |
There was a problem hiding this comment.
************* Module py.test_runner
C:124, 0: Trailing whitespace (trailing-whitespace)
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
I believe that we could pass the test now. |
|
@lluunn Can you LGTM please? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi, lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetmuffin
pushed a commit
to jetmuffin/tf-operator
that referenced
this pull request
Jul 9, 2018
* Support testing on minikube. * When using minikube we don't want call configure_kubectl which calls gcloud container clusters get-credentials. * Instead we just need to call load_kube_config to load the kube config file. * Related to kubeflow/testing#6 * Add a TODO. * Fix lint issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using minikube we don't want call configure_kubectl which calls
gcloud container clusters get-credentials.
Instead we just need to call load_kube_config to load the kube config file.
Related to minikube testing testing#6
This change is