Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support testing on minikube. #485

Merged
merged 6 commits into from
Mar 26, 2018
Merged

Support testing on minikube. #485

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b01844
Support testing on minikube.
jlewi Mar 21, 2018
3fbae39
Add a TODO.
jlewi Mar 21, 2018
6934338
Merge remote-tracking branch 'upstream/master' into minikube_test
jlewi Mar 23, 2018
a78eda4
Merge remote-tracking branch 'upstream/master' into minikube_test
jlewi Mar 23, 2018
d23ba90
Fix lint issue.
jlewi Mar 23, 2018
803b399
Merge remote-tracking branch 'upstream/master' into minikube_test
jlewi Mar 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion py/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,16 @@ def run_test(args): # pylint: disable=too-many-branches,too-many-statements
project = args.project
cluster_name = args.cluster
zone = args.zone
util.configure_kubectl(project, zone, cluster_name)
# TODO(jlewi): When using GKE we should copy the .kube config and any other
# files to the test directory. We should then set the environment variable
# KUBECONFIG to point at that file. This should prevent us from having
# to rerun util.configure_kubectl on each step. Instead we could run it once
# as part of GKE cluster creation and store the config in the NFS directory.
# This would make the handling of credentials
# and KUBECONFIG more consistent between GKE and minikube and eventually
# this could be extended to other K8s deployments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

************* Module py.test_runner
C:124, 0: Trailing whitespace (trailing-whitespace)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

if cluster_name:
util.configure_kubectl(project, zone, cluster_name)
util.load_kube_config()

api_client = k8s_client.ApiClient()
Expand Down
1 change: 1 addition & 0 deletions py/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Utilities used by our python scripts for building and releasing."""
from __future__ import print_function

# TODO(jlewi): We should remove this file and use util in kubeflow/testing repository.
import datetime
import logging
import os
Expand Down