-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tensorflow: Support old versions of estimator #809
Conversation
Support Master spec similar to Chief Signed-off-by: Ce Gao <gaoce@caicloud.io>
@@ -53,8 +53,8 @@ func updateStatusSingle(tfjob *tfv1alpha2.TFJob, rtype tfv1alpha2.TFReplicaType, | |||
tfjob.Status.StartTime = &now | |||
} | |||
|
|||
if ContainChiefSpec(tfjob) { | |||
if rtype == tfv1alpha2.TFReplicaTypeChief { | |||
if ContainChieforMasterSpec(tfjob) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be add a comment saying that it is added for backwards compatibility?
Travis tests have failedHey @gaocegege, 2nd Buildgometalinter --config=linter_config.json --vendor ./...
3rd Buildgometalinter --config=linter_config.json --vendor ./...
|
Related to issue kubeflow/kubeflow#1442 |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Support Master spec similar to Chief
Close #794
/assign @johnugeorge @jlewi
Signed-off-by: Ce Gao gaoce@caicloud.io
This change is