Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility support "Master" as chief #794

Closed
jlewi opened this issue Aug 24, 2018 · 1 comment
Closed

Backwards compatibility support "Master" as chief #794

jlewi opened this issue Aug 24, 2018 · 1 comment

Comments

@jlewi
Copy link
Contributor

jlewi commented Aug 24, 2018

For backwards compatibility with older versions of TF.estimator we need to treat replicas with name "Master" as "Chief".

One place where this doesn't seem to be happening is the exit policy. If there is a replica of type, "Master" than TFJob should be marked completed when the "Master" exits. It would be good to add an E2E test for this case.

We should probably add validation to ensure only "Master" or "Chief" is provided.

@ScorpioCPH Would you be willing to pick this up?

@gaocegege
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants