feat: ensure that tfjob crd exists. #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
Travis tests have failedHey @Muzry, 3rd Buildgometalinter --config=linter_config.json --vendor ./... |
|
Thanks for your contribution! Please fix the linting issues in Travis CI https://travis-ci.org/kubeflow/tf-operator/jobs/424162654#L504: |
|
/assign @johnugeorge @gaocegege |
|
/ok-to-test |
gaocegege
reviewed
Sep 4, 2018
cmd/tf-operator.v2/app/server.go
Outdated
| @@ -38,10 +38,12 @@ import ( | |||
| controller "github.com/kubeflow/tf-operator/pkg/controller.v2/tensorflow" | |||
| "github.com/kubeflow/tf-operator/pkg/util/signals" | |||
| "github.com/kubeflow/tf-operator/pkg/version" | |||
| crdclient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset" | |||
There was a problem hiding this comment.
Please put the dep after https://github.com/kubeflow/tf-operator/pull/820/files#diff-4c0b4e5eb33fd600a68479ae73e49d8aL31
cmd/tf-operator.v2/app/server.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| apiVersion = "v1alpha2" | ||
| TFCRD = "tfjobs.kubeflow.org" |
There was a problem hiding this comment.
I think we'd better define the field here: https://github.com/kubeflow/tf-operator/blob/master/pkg/apis/tensorflow/v1alpha2/register.go
cmd/tf-operator.v2/app/server.go
Outdated
| @@ -159,6 +161,23 @@ func Run(opt *options.ServerOption) error { | |||
| } | |||
|
|
|||
| func createClientSets(config *restclientset.Config) (kubeclientset.Interface, kubeclientset.Interface, tfjobclientset.Interface, error) { | |||
|
|
|||
| crdClient,err := crdclient.NewForConfig(config) | |||
| crdList, err := crdClient.ApiextensionsV1beta1().CustomResourceDefinitions().List(metav1.ListOptions{}) | |||
There was a problem hiding this comment.
I am wondering why we use list here. Could we follow the implementation as coreos/etcd-operator does https://github.com/coreos/etcd-operator/blob/c8f63d508266990a4d20718d94363c30e75e6282/pkg/util/k8sutil/crd.go#L79 ?
|
/retest |
Travis tests have failedHey @Muzry, 1st Buildgometalinter --config=linter_config.json --vendor ./...3rd Buildgometalinter --config=linter_config.json --vendor ./... |
Travis tests have failedHey @Muzry, 3rd Buildgometalinter --config=linter_config.json --vendor ./... |
|
@Muzry Planning to get this in 0.3 release? |
Travis tests have failedHey @Muzry, 2nd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go"3rd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go"TravisBuddy Request Identifier: 3bc26510-cc6c-11e8-9706-8d7bf71fb7b5 |
Muzry
force-pushed
the
develop
branch
2 times, most recently
from
5873dfe
to
8550dc4
Compare
Travis tests have failedHey @Muzry, 2nd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go"3rd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go"TravisBuddy Request Identifier: cc297580-cc71-11e8-9706-8d7bf71fb7b5 |
Travis tests have failedHey @Muzry, 2nd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go"3rd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go"TravisBuddy Request Identifier: 62a4b6a0-cc72-11e8-9706-8d7bf71fb7b5 |
gaocegege
reviewed
Oct 10, 2018
| @@ -39,6 +39,7 @@ const ( | |||
| Plural = "tfjobs" | |||
| // Singular is the singular for TFJob. | |||
| Singular = "tfjob" | |||
| TFCRD = "tfjobs.kubeflow.org" | |||
There was a problem hiding this comment.
Please add the comment for the field.
|
/cc @johnugeorge |
This comment has been minimized.
This comment has been minimized.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#710
This pr ensure that tfjob crd exists, if not tf-operator will exit.
This change is