Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example for TF distributed training #860

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Add an example for TF distributed training #860

merged 2 commits into from
Nov 1, 2018

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Oct 31, 2018 •
edited by jlewi
Loading

Fixes #843

This change is Reviewable

@richardsliu
Copy link
Contributor Author

/retest

@coveralls
Copy link

Coverage Status

Coverage increased (+4.5%) to 61.654% when pulling 73e31bd on richardsliu:dist_example into 513e107 on kubeflow:master.

@richardsliu
Copy link
Contributor Author

/cc @yuefengz

@k8s-ci-robot
Copy link

@richardsliu: GitHub didn't allow me to request PR reviews from the following users: yuefengz.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yuefengz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardsliu
Copy link
Contributor Author

/assign @lluunn

@richardsliu richardsliu mentioned this pull request Oct 31, 2018
Closed
@ChanYiLin
Copy link
Member

/lgtm

gaocegege
gaocegege approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit abb3134 into kubeflow:master Nov 1, 2018
@richardsliu richardsliu deleted the dist_example branch November 1, 2018 17:27
yuefengz
yuefengz reviewed Nov 2, 2018
View reviewed changes
Copy link

@yuefengz yuefengz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding distribution strategy support!

examples/distribution_strategy/Dockerfile
@@ -0,0 +1,4 @@
FROM tensorflow/tensorflow:1.11.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually already have 1.12.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought 1.12 is still in pre-release.

examples/distribution_strategy/distributed_tfjob.yaml
@@ -0,0 +1,16 @@
apiVersion: "kubeflow.org/v1alpha2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and is much simpler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuefengz yuefengz yuefengz left review comments

@gaocegege gaocegege gaocegege approved these changes

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@ddysher ddysher Awaiting requested review from ddysher

Assignees

@ChanYiLin ChanYiLin

@lluunn lluunn

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@richardsliu @coveralls @k8s-ci-robot @ChanYiLin @yuefengz @gaocegege @lluunn