Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "good first issue" and "help wanted" links in contrib guide to include all of Kubeflow org #1332

Closed
sarahmaddox opened this issue Nov 10, 2019 · 7 comments · Fixed by #1406 or #1411
Assignees

Comments

@sarahmaddox
Copy link
Contributor

On this page:
https://www.kubeflow.org/docs/about/contributing/#starter-issues

Change the link for good first issue to include all of Kubeflow org, not just kubeflow/kubeflow: use this link
https://github.com/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+org%3Akubeflow

Similarly for the help wanted label.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.77. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@sarahmaddox sarahmaddox added the good first issue Good for newcomers label Nov 10, 2019
@sarahmaddox
Copy link
Contributor Author

FYI - this answers a question that came up a few times at the contributor summit
/cc @theadactyl
/cc @abhi-g
/cc @jlewi

@abhi-g
Copy link
Member

abhi-g commented Nov 11, 2019

Thanks for creating the issue @sarahmaddox. I agree we should update it.

@jlewi
Copy link
Contributor

jlewi commented Nov 23, 2019

@deepak2431 unfortunately I think we need to revert #1406 . The link only works if you are a member of the kubeflow GitHub org

https://github.com/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+org%3Akubeflow

You can try it in an incognito browser; I get a 404.

I don't know of anyway to search issues in an org without being a member of the org.

@jlewi
Copy link
Contributor

jlewi commented Nov 23, 2019

@deepak2431 would you mind opening a PR to revert your change?

@deepak2431
Copy link
Contributor

@jlewi Hi, sure I will make a pull request by reverting back the changes. I have tested the link got the same error as you have mentioned above.
Thanks!

@sarahmaddox
Copy link
Contributor Author

/assign

Thanks for the work on this, @deepak2431, and my apologies for not realizing that the suggested links work only for members of the Kubeflow org on GitHub.

I'll take this issue over. I think a good solution is to offer two versions of the "good first" issue link, for two different repos, and suggest that people look at the "good first issue" label in other repos too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants