Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed link of "good first issue" and "help wanted" #1410

Merged
merged 3 commits into from Nov 24, 2019

Conversation

deepak2431
Copy link
Contributor

@deepak2431 deepak2431 commented Nov 23, 2019

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @deepak2431. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepak2431
Copy link
Contributor Author

@sarahmaddox @jlewi I have reverted back the changes. Please review the PR.

Copy link
Contributor

@sarahmaddox sarahmaddox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the links again! The updated links aren't right yet, though. I've added some details in the review comments.

content/docs/about/contributing.md Outdated Show resolved Hide resolved
content/docs/about/contributing.md Outdated Show resolved Hide resolved
@sarahmaddox
Copy link
Contributor

/assign
/ok-to-test

@deepak2431
Copy link
Contributor Author

@sarahmaddox I have updated the links. Please review it.
Thanks!

@sarahmaddox
Copy link
Contributor

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarahmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sarahmaddox
Copy link
Contributor

/retest

@sarahmaddox sarahmaddox merged commit 69b6695 into kubeflow:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants