Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.1] Release Website 1.1 #1984

Closed
jlewi opened this issue Jun 9, 2020 · 66 comments
Closed

[Release 1.1] Release Website 1.1 #1984

jlewi opened this issue Jun 9, 2020 · 66 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jun 9, 2020

Opening this issue to track doing a release of the website for Kubeflow 1.1

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/docs 1.00
kind/feature 0.73

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor Author

jlewi commented Jun 10, 2020

It looks like we might want to branch 1.0 on
https://github.com/kubeflow/website/tree/61b5ed89590fe961c26d18da30969f3841dbf93a

After that it looks like we start getting commits related to 1.1

@rui-vas
Copy link
Contributor

rui-vas commented Jun 12, 2020

Hi Jeremy,

As soon as I get access to the repo I'll push that branch up.

As far as netlify, is that automatic or are there any additional steps?

@jlewi
Copy link
Contributor Author

jlewi commented Jun 15, 2020

@RFMVasconcelos

As soon as I get access to the repo I'll push that branch up.

Please read:
https://groups.google.com/forum/#!topic/kubeflow-discuss/pGflW6m9Xrg

And please file PRs.

As far as netlify, is that automatic or are there any additional steps?

Is what automatic?

@jlewi jlewi moved this from To do to release-infra in Kubeflow 1.1 Jun 15, 2020
@rui-vas
Copy link
Contributor

rui-vas commented Jun 16, 2020

Hi @jlewi, thank you for the guidance!!

Please read:

I'm going through all the guidelines. Signed CLA, ready to start contributing :)

And please file PRs.

Will do! Started out with this one: #1999

Is what automatic?

I haven't used netlify before. Was wondering what I needed to know to render the website, or if it was automatic.

@8bitmp3
Copy link
Contributor

8bitmp3 commented Jun 16, 2020

Hey @RFMVasconcelos I left some suggestions in your PR #1999. (I'm not an official editor but a few things may need to be reviewed by you before the official PR review.)

@jlewi
Copy link
Contributor Author

jlewi commented Jun 16, 2020

@RFMVasconcelos The website is automatically updated once PR is merged.

Checkout the quickstart: https://github.com/kubeflow/website#quickstart

When you create a PR it will automatically create preview for you of the rendered website.

@8bitmp3
Copy link
Contributor

8bitmp3 commented Jun 16, 2020

@jlewi Will you be open to accepting PRs about streamlining Kubeflow's Getting Started section? I think it was @LyleHenkeman who posted about it here. If you are open to improvements, I can work on it and submit a PR. @LyleHenkeman - I did spend a bit of time working through the steps because I was initially interested in the KF CLI and Pipelines, so I think I get why the current guide is a bit "busy". Cheers

@jlewi
Copy link
Contributor Author

jlewi commented Jun 16, 2020

@8bitmp3 Yes; would you mind opening an issue and maybe outlining your changes before getting started on a PR?

@jlewi
Copy link
Contributor Author

jlewi commented Jun 16, 2020

@jlewi
Copy link
Contributor Author

jlewi commented Jun 16, 2020

@jlewi
Copy link
Contributor Author

jlewi commented Jun 16, 2020

The deployment on the v1.0-branch is failing.

3:29:00 PM: $ hugo
3:29:01 PM: Building sites …
3:29:02 PM: ERROR 2020/06/16 22:29:02 error: failed to transform resource: POSTCSS: failed to transform "scss/main.css" (text/css): PostCSS not found; install with "npm install postcss-cli". See https://gohugo.io/hugo-pipes/postcss/
3:29:05 PM: Total in 3836 ms
3:29:05 PM: Error: Error building site: logged 1 error(s)
3:29:05 PM: ​
3:29:05 PM: ┌─────────────────────────────┐
3:29:05 PM: │   "build.command" failed    │
3:29:05 PM: └─────────────────────────────┘
3:29:05 PM: ​
3:29:05 PM:   Error message
3:29:05 PM:   Command failed with exit code 255: hugo
3:29:05 PM: ​
3:29:05 PM:   Error location
3:29:05 PM:   In build.command from netlify.toml:
3:29:05 PM:   hugo
3:29:05 PM: ​
3:29:05 PM:   Resolved config
3:29:05 PM:   build:
3:29:05 PM:     command: hugo
3:29:05 PM:     publish: /opt/build/repo/public

@jlewi
Copy link
Contributor Author

jlewi commented Jun 16, 2020

Not sure why that's only happening on the branch. We will need to get that fixed.
Does anyone want to investigate?

@jlewi
Copy link
Contributor Author

jlewi commented Jun 19, 2020

#2001 is fixed. v1-0-branch is now serving
https://v1-0-branch--competent-brattain-de2d6d.netlify.app/

There was an existing cname record

For v1.0.kubeflow.org ; it was point at
https://master--competent-brattain-de2d6d.netlify.app/

I updated it to point at the v1-0 branch

There was a cname record for www.kubeflow.org pointing at 0.7; I updated it to point at master.
I'm not sure that CNAME record actually matters.

I think we may need to change netlify to make the 1.0 branch the main branch.

@jlewi
Copy link
Contributor Author

jlewi commented Jun 19, 2020

https://v1-0.kubeflow.org/

Giving a DNS error.
DNS_PROBE_FINISHED_NXDOMAIN

nslookup v1-0.kubeflow.org
Server:		127.0.0.1
Address:	127.0.0.1#53

Non-authoritative answer:
v1-0.kubeflow.org	canonical name = v1-0-branch--competent-brattain-de2d6d.netlify.app/.
Name:	v1-0-branch--competent-brattain-de2d6d.netlify.app/
Address: 23.217.138.110
Name:	v1-0-branch--competent-brattain-de2d6d.netlify.app/
Address: 23.202.231.169

Lets give it a bit more time to propogate

@jlewi
Copy link
Contributor Author

jlewi commented Jun 19, 2020

There is a typo in the CNAME record; there should be a trailing "/" on the value. I fixed that; still waiting for it to propogate.

@jlewi
Copy link
Contributor Author

jlewi commented Jun 19, 2020

curl --insecure https://v1-0.kubeflow.org

Returning 404

@jlewi
Copy link
Contributor Author

jlewi commented Jun 19, 2020

Filed a support request to the certificate updated; still no idea why I'm still getting 404s.

@8bitmp3
Copy link
Contributor

8bitmp3 commented Jun 19, 2020

Same, "Not Found".

@jlewi
Copy link
Contributor Author

jlewi commented Jun 19, 2020

The 404 is fixed. Netlify told me that I had the subdomain name wrong; it needs to match the branch name so the cname record needs to be "v1-0-branch"
https://v1-0-branch.kubeflow.org/

This is now accessible but with an SSL error. Will ask Netlify to take care of the certificate

@jlewi
Copy link
Contributor Author

jlewi commented Jun 20, 2020

Certificate should be fixed as well.

@jlewi
Copy link
Contributor Author

jlewi commented Aug 4, 2020

At the meeting we decided we will flip over the website to the 1.1 docs as soon as the KFP docs are updated to reflect multi-user.

@Bobgy Are the docs already updated for multiuser or can we get them updated.

@Bobgy
Copy link
Contributor

Bobgy commented Aug 5, 2020

I have been writing docs full time in recent days.
I have one more item to finish, it will need 1 day for review. So I am targetting end of this week.

EDIT: tracking issue: kubeflow/pipelines#4317

@8bitmp3
Copy link
Contributor

8bitmp3 commented Aug 6, 2020

I understand there're still quite a few moving parts with various stakeholders. I've just reviewed a couple of fairly large PRs (#2056 and #2071).

@8bitmp3
Copy link
Contributor

8bitmp3 commented Aug 6, 2020

I've also reviewed #2019 @RFMVasconcelos which is related to another PR of yours.

@Bobgy
Copy link
Contributor

Bobgy commented Aug 8, 2020

KFP multi-user doc all clear
@jlewi

@jlewi
Copy link
Contributor Author

jlewi commented Aug 10, 2020

@rui5i @8bitmp3 Now that the 1.0 branch is published we should be able to updown the version selector to include the 1.0 docs. Could one of you please send a PR to do that?

@8bitmp3
Copy link
Contributor

8bitmp3 commented Aug 10, 2020

Just reviewed @Bobgy 's PR #2101 - it's a guide (KF v1.1) on Updating Kubeflow Pipelines deployment on Google Cloud

@8bitmp3
Copy link
Contributor

8bitmp3 commented Aug 10, 2020

@rui5i @8bitmp3 Now that the 1.0 branch is published we should be able to updown the version selector to include the 1.0 docs. Could one of you please send a PR to do that?

@jlewi I'm sure @rui5i or I can assist 👍 Can you point us (especially me) to the steps in https://github.com/kubeflow/kubeflow/blob/master/docs_dev/releasing.md#updating-version-numbers-etc-for-the-upcoming-release-major-minor-or-patch ? Thank you for all the help

@jlewi
Copy link
Contributor Author

jlewi commented Aug 10, 2020

@8bitmp3 Its step two updating config.toml

@8bitmp3
Copy link
Contributor

8bitmp3 commented Aug 10, 2020

Finished (final) review of KFP installation on kind, k3s and k3s on WSL (Windows) #2056 (review)

@animeshsingh
Copy link
Contributor

@shawnzhu @adrian555 @vpavlin this page might need an update from your perspective
https://www.kubeflow.org/docs/started/getting-started/

@adrian555
Copy link
Member

@jlewi and @animeshsingh, do you know who are maintaining the istio and istio-dex? There are not v1.1.0 version for these two. If no plan to maintain a v1.1.0 version, I will have to use a different kfdef for the kfctl guide.

@jlewi
Copy link
Contributor Author

jlewi commented Aug 11, 2020

@adrian555 Primary owners of the istio dex configs should be @krishnadurai and @yanniszark

@jlewi
Copy link
Contributor Author

jlewi commented Aug 11, 2020

@8bitmp3 and @RFMVasconcelos Can we prioritize updating config.toml so the versions drop down shows the link to the 1.0 docs? Right now users can't find the 1.0 docs. Someone is asking about this in slack.

@8bitmp3
Copy link
Contributor

8bitmp3 commented Aug 12, 2020

@jlewi 👍 #2111

swiftdiaries added a commit to swiftdiaries/manifests that referenced this issue Aug 18, 2020
swiftdiaries added a commit to swiftdiaries/manifests that referenced this issue Aug 18, 2020
k8s-ci-robot pushed a commit to kubeflow/manifests that referenced this issue Aug 19, 2020
* v1.1 istio dex components for kubernetes installation (#1494)

* v1.1 istio dex components for kubernetes installation

* Adds kfdef and creds correction

* Test cases generated

* v1.1.0 kfdef added

(cherry picked from commit 6dcebbe)

* v1.1 manifests for vanilla k8s (#1483)

* v1.1 manifests for vanilla k8s

* adds k8s_istio v3 kfdef

* add tests

(cherry picked from commit c429076)

* Fix tests

[Issue: kubeflow/kubeflow#5022]
[See also: kubeflow/website#1984]
@stale
Copy link

stale bot commented Nov 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@rui-vas rui-vas closed this as completed Nov 10, 2020
Kubeflow 1.1 automation moved this from release-infra to Done Nov 10, 2020
saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 11, 2021
…eflow#5084)

* Update docs for releasing the website.

related to kubeflow/website#1984

* Prune owners file as well.
saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 12, 2021
…eflow#5084)

* Update docs for releasing the website.

related to kubeflow/website#1984

* Prune owners file as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Kubeflow 1.1
  
Done
Development

No branches or pull requests

7 participants