New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website guide #143
Merged
Merged
Website guide #143
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ce3003f
Initial commit of new page.
sarahmaddox 5b392d5
Adds more how-to info to the website README.
sarahmaddox fc533dd
Delete gcp-e2e.md
sarahmaddox 39a3444
Merge branch 'master' into website-guide
sarahmaddox b7ddd8c
Separates the doc updating guide into sections
sarahmaddox File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why go to the trouble of running hugo locally? If users want to do a preview they can just create a PR and we will automatically generate a preview they can look at?
If the PR isn't ready for review they can just mark it WIP.
Can we add this as an alternative path and make it clear that its less work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I didn't know we automatically generate a preview. How/where can I see that preview? I guess that may become clear the first time I submit a PR for a web page, but as someone putting together my first website PR I had no idea that will happen. I therefore assumed I had to run my own Hugo server. I've spent quite some time reading the Hugo docs, and then figuring out how to fit them into our own situation. It'd be good to help others avoid doing the same work, by adding this info to the guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll figure out how the generated preview happens for a PR, and include it in this update.
/hold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've figured out I should probably add "draft = true" to the page front matter, to indicate to Hugo that this is a draft. Done that. But even after reading all the Hugo docs and our config files, I can't figure out what the URL is where the draft matter should show up. Please would you ping me the URL? In case it's useful, here's my PR with draft content: #151