Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more instructions and screenshots to setup authentication in AWS #1838

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Add more instructions and screenshots to setup authentication in AWS #1838

merged 2 commits into from
Mar 25, 2020

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Mar 24, 2020

No description provided.

@kubeflow-bot
Copy link

This change is Reviewable

@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 24, 2020

@theofpa Please have a check.

@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 24, 2020

/cc @sarahmaddox

@theofpa
Copy link
Member

theofpa commented Mar 24, 2020

@theofpa Please have a check.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@theofpa: changing LGTM is restricted to collaborators

In response to this:

@theofpa Please have a check.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sarahmaddox
Copy link
Contributor

Thanks @Jeffwan and @theofpa
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarahmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sarahmaddox
Copy link
Contributor

@Jeffwan Please would you resolve the merge conflicts?

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 25, 2020
@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 25, 2020

@sarahmaddox just rebase the upstream changes.

@cloudbow
Copy link

cloudbow commented Mar 25, 2020 •
edited

+100 for this as it is self explanatory now

@sarahmaddox
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b1c1cc2 into kubeflow:master Mar 25, 2020
@Jeffwan Jeffwan deleted the aws_cognito branch March 26, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchihe jinchihe Awaiting requested review from jinchihe

@paveldournov paveldournov Awaiting requested review from paveldournov

@sarahmaddox sarahmaddox Awaiting requested review from sarahmaddox

Assignees

@sarahmaddox sarahmaddox

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jeffwan @kubeflow-bot @theofpa @k8s-ci-robot @sarahmaddox @cloudbow