New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State compatibility with Kubernetes 1.16 #1933
Conversation
Hi @saschagrunert. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If anyone has experiences with Kubernetes 1.17 and 1.18 in conjunction with Kubeflow 1.0, then I'm happy to add them to the docs as well. |
Thanks @saschagrunert for submitting this PR. @jlewi |
/assign @janeman98 |
looking forward for this PR, documentation still stating it is incompatible |
/assign @jlewi |
As discussed in kubeflow/manifests#375 we don't have any test automation indicating that things are working on K8s 1.16. The only automated tests we have are for GKE 1.14. Should we reserve "compatible" designation for cases where we have test automation? Should we draw a distinction between "verified" and "no known issues". |
@jlewi this sounds perfect, let's have 3 distinct states:
Maybe we could show verified using a check emoji ✔️ @saschagrunert do you think you could amend the PR for something along these lines? (for k8s 1.17 and 1.18 as well). |
We can update the documentation since it seems that Kubeflow 1.0 is compatible with Kubernetes 1.16. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
Sure, I updated the PR, please take a look. 👍 |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We can update the documentation since it seems that Kubeflow 1.0 is
compatible with Kubernetes 1.16.