Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State compatibility with Kubernetes 1.16 #1933

Merged
merged 1 commit into from Jun 4, 2020

Conversation

saschagrunert
Copy link
Contributor

We can update the documentation since it seems that Kubeflow 1.0 is
compatible with Kubernetes 1.16.

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @saschagrunert. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Contributor Author

If anyone has experiences with Kubernetes 1.17 and 1.18 in conjunction with Kubeflow 1.0, then I'm happy to add them to the docs as well.

@janeman98
Copy link
Contributor

Thanks @saschagrunert for submitting this PR.

@jlewi
Are we ready to change the documentation to support Kubernetes 1.16? I heard the team is working on that some time ago. @saschagrunert is using Kubernetes 1.16, just want to make sure everything work with Kubernetes 1.16.

@sarahmaddox
Copy link
Contributor

/assign @janeman98

@robertmujica
Copy link

looking forward for this PR, documentation still stating it is incompatible

@janeman98
Copy link
Contributor

/assign @jlewi
Are we ready to change the documentation for this?

@jlewi
Copy link
Contributor

jlewi commented May 8, 2020

As discussed in kubeflow/manifests#375 we don't have any test automation indicating that things are working on K8s 1.16. The only automated tests we have are for GKE 1.14.

Should we reserve "compatible" designation for cases where we have test automation? Should we draw a distinction between "verified" and "no known issues".

/cc @animeshsingh @yanniszark @johnugeorge

@yanniszark
Copy link
Contributor

@jlewi this sounds perfect, let's have 3 distinct states:

  • Incompatible: Kubeflow release in incompatible with K8s version. An issue link would help.
  • Compatible (no known issues): No known issues on deploying this Kubeflow release on the specific k8s version, but this is not validated by CI.
  • Compatible (verified): Deployment is verified with CI.

Maybe we could show verified using a check emoji ✔️
At any case, we need to communicate this to users asap because issues about k8s compatibility are piling up, meaning that users are getting the wrong picture.

@saschagrunert do you think you could amend the PR for something along these lines? (for k8s 1.17 and 1.18 as well).
Everything is Compatible (no known issues) except 1.14.
@jlewi are you ok with that?

We can update the documentation since it seems that Kubeflow 1.0 is
compatible with Kubernetes 1.16.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Contributor Author

Sure, I updated the PR, please take a look. 👍

@jlewi
Copy link
Contributor

jlewi commented Jun 4, 2020

/ok-to-test
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants