Correct metadata inaccuracy in the output viewer documentation #2212
Conversation
This corrects a misleading sentence in the output viewer documentation, where the docs suggest the file name matters, but in reality the artifact name is what matters.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This change is |
|
Hi @lucinvitae. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @Bobgy |
|
I'm not sure why CI is failing for this PR. It runs locally for me with Screenshot: |
This corrects a misleading sentence in the pipeline metrics documentation, where the docs suggest the file name matters, but in reality the artifact name is what matters. This is similar to kubeflow#2212.
|
/assign @alfsuse |
|
/retest |
|
/test all |
|
Closing and reopening to try to fix CI issues as suggested by reviewer. CI issue shows Looks like there’s some more context… I think the -race option may show it’s a data race. For this issue, @bep opened gohugoio/hugo#5926 in May and golang/go#39807 in June… @andreasf tried to fix in https://github.com/gohugoio/hugo/pull/7507/files but @bep rejected, citing that template rendering in hugo has always been done in parallel, and that he doesn’t want to maintain custom parser code, and appears to be waiting on a fix in golang itself. |
|
Hey, I've had a patch for this in my Golang branch for a while. The fix in Golang is the same as in the Hugo copy of text/template. In our Hugo pipeline, we wrapped |
* Correct requirement inaccuracy in the metrics documentation This corrects a misleading sentence in the pipeline metrics documentation, where the docs suggest the file name matters, but in reality the artifact name is what matters. This is similar to #2212. * Wrap new metrics documentation paragraph lines at 80 chars
This corrects a misleading sentence in the output viewer documentation, where the docs suggest the file name matters, but in reality the artifact name is what matters.