Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Notebook web app link #2761

Merged
merged 1 commit into from Jun 11, 2021
Merged

fix Notebook web app link #2761

merged 1 commit into from Jun 11, 2021

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jun 10, 2021

fix issue #2756

@google-oss-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-cla google-cla bot added the cla: yes label Jun 10, 2021
@Arhell
Copy link
Member Author

Arhell commented Jun 10, 2021

/assign @terrytangyuan

@Arhell Arhell marked this pull request as ready for review June 10, 2021 21:33
@Arhell
Copy link
Member Author

Arhell commented Jun 10, 2021

/assign @RFMVasconcelos

@Arhell
Copy link
Member Author

Arhell commented Jun 11, 2021

/assign @Bobgy

@Arhell
Copy link
Member Author

Arhell commented Jun 11, 2021

cc @terrytangyuan

terrytangyuan
terrytangyuan approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Arhell, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 2133794 into kubeflow:master Jun 11, 2021
@Arhell Arhell deleted the fix-link branch June 11, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@terrytangyuan terrytangyuan

@Bobgy Bobgy

@rui-vas rui-vas

Labels
approved cla: yes lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Arhell @google-oss-robot @terrytangyuan @Bobgy @rui-vas