Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken localcluster-deployment page link #3181

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

thliang01
Copy link
Contributor

@thliang01 thliang01 commented Mar 5, 2022

Small change: fixed broken link.

@google-oss-prow
Copy link

Hi @thliang01. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thliang01
Copy link
Contributor Author

/assign @chensun

@chensun
Copy link
Member

chensun commented Mar 7, 2022

@thliang01 the change itself looks fine, but I think your PR description needs a bit fix.

@thliang01 thliang01 changed the title Fix broken localcluster-deployment page hyperlink Fix broken localcluster-deployment page link Mar 7, 2022
@thliang01
Copy link
Contributor Author

@chensun I change my PR description. Could you give me some feedback.

@shannonbradshaw
Copy link
Contributor

/approve

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shannonbradshaw, thliang01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 56680e6 into kubeflow:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants