Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated contributors table link #3657

Merged
merged 1 commit into from
May 8, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Jan 5, 2024

This PR updates the contributors table link.
Fixes #3732.

Copy link

Hi @hbelmiro. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@thesuperzapper
Copy link
Member

@hbelmiro what is wrong with the existing link?

It seems to work for me: http://devstats.kubeflow.org/d/9/developers-summary

@hbelmiro
Copy link
Contributor Author

hbelmiro commented Jan 10, 2024

@thesuperzapper It works, but it seems outdated. I don't see myself on that list, for example.
Also, that's the link we see here.

@rimolive
Copy link
Member

@hbelmiro what is wrong with the existing link?

It seems to work for me: http://devstats.kubeflow.org/d/9/developers-summary

I'm getting this error when accessing the URL:
Screenshot from 2024-02-15 18-23-42

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
@rimolive
Copy link
Member

rimolive commented May 6, 2024

/lgtm

@thesuperzapper
Copy link
Member

With the new CNCF link, this should be good to merge.

@andreyvelich can you approve?

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @hbelmiro!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 24bc65e into kubeflow:master May 8, 2024
6 checks passed
@hbelmiro hbelmiro deleted the contributors-table branch May 8, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contributions table not showing
5 participants