Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated legal info due to migration from CLA to DCO #3682

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

hbelmiro
Copy link
Contributor

This PR depends on kubeflow/community#703.

The Legal text is based on Argo Project.

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Copy link

Hi @hbelmiro. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @kubeflow/kubeflow-steering-committee

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@diegolovison
Copy link

diegolovison commented Feb 29, 2024

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@terrytangyuan
Copy link
Member

/hold

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
Copy link
Member

Can you address the comments above?

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Mar 1, 2024
@hbelmiro
Copy link
Contributor Author

hbelmiro commented Mar 1, 2024

Duplicated info removed.
Can you please take a second look, @terrytangyuan and @diegolovison?

@terrytangyuan
Copy link
Member

/unhold

@terrytangyuan
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 1, 2024
@google-oss-prow google-oss-prow bot merged commit bfb418f into kubeflow:master Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants