Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katib: Reorganized Katib Docs #3723

Merged
merged 21 commits into from
May 8, 2024

Conversation

andreyvelich
Copy link
Member

Fixes: kubeflow/katib#2314, kubeflow/katib#1672.

I reorganized Katib doc based on our recent discussions.

Still need to finish some docs:

  • Add Why Katib? sections.
  • Add AI/ML Lifecycle Diagram.

@StefanoFioravanzo Please let me know what do you think about this doc structure.

/assign @StefanoFioravanzo @droctothorpe @kubeflow/wg-training-leads @hbelmiro @droctothorpe @franciscojavierarceo

@andreyvelich
Copy link
Member Author

/hold for review

@andreyvelich
Copy link
Member Author

This PR should be ready for review.
@StefanoFioravanzo @hbelmiro @kubeflow/wg-training-leads Please let me know what do you think about new doc structure?

@andreyvelich andreyvelich changed the title [WIP] Katib: Reorganized Katib Docs Katib: Reorganized Katib Docs Apr 26, 2024
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

title = "Environment Variables for Katib Components"
description = "How to set up environment variables for each Katib component"
title = "How to Configure Environment for Katib Components"
description = "List of environment variables that accepted by Katib components"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "List of environment variables that accepted by Katib components"
description = "List of environment variables accepted by Katib components"

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically lgtm!

- Katib [installed](/docs/components/katib/installation/#installing-katib).
- Katib Python SDK [installed](/docs/components/katib/installation/#installing-katib-python-sdk).

## Getting Started with Katib Python SDK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we can the guide about ## Getting Started with kubectl here as well.
If we can add that, I think that we can move https://github.com/kubeflow/katib/tree/1551ca3975ed50a5af3946bb8847e908888ce27e/examples/v1beta1/kind-cluster to here.

@andreyvelich WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is interesting, but I already added the section about getting started with Experiment YAML.
For me the kind guides relate to Developer guides section since prerequisite for Katib getting started is to install Katib Control Plane.
Eventually, we want to split our docs like this:

  • User Guides (how to run Katib Experiments)
  • Administrators Guides (how to install and configure Katib ControlPlane)
  • Developer Guides (how to contribute and develop Katib platform)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is interesting, but I already added the section about getting started with Experiment YAML.

Oh, I was missing the section. So, I'm ok with keeping the current getting started. Thanks!

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 30, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@google-oss-prow google-oss-prow bot removed the lgtm label May 2, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@andreyvelich
Copy link
Member Author

@StefanoFioravanzo I made your suggested changes, please let me know what do you think.

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@thesuperzapper
Copy link
Member

@andreyvelich so we don't end up with 404 errors (which hurt SEO and confuse users), can you please add redirects for any pages that you have removed/renamed?

You need to update this file: https://github.com/kubeflow/website/blob/master/content/en/_redirects

@andreyvelich
Copy link
Member Author

@andreyvelich so we don't end up with 404 errors (which hurt SEO and confuse users), can you please add redirects for any pages that you have removed/renamed?

You need to update this file: https://github.com/kubeflow/website/blob/master/content/en/_redirects

It's a good point! I will update it.

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@andreyvelich
Copy link
Member Author

@StefanoFioravanzo Thanks again for your great review!
Do you have any other suggestions for this PR ?

@@ -70,7 +70,6 @@
docs/started/requirements/ /docs/started/getting-started/

# Created a new components layout
/docs/components/hyperparameter /docs/components/katib/overview
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's usually best to leave the old redirects, as it creates history, and is fine to chain them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesuperzapper I didn't remove the old redirect, I just moved it below:

/docs/components/hyperparameter /docs/components/katib/overview

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich yea, don't do that, as it might break a subsequent redirects that have happened since (if the page has been moved multiple times).

We should only add things to the end of the file. That lets us assume that the current state of the website already has its redirects set up, so we only add new redirects for the actual changes we have made.

@StefanoFioravanzo
Copy link
Member

@andreyvelich thank you for putting so much effort on this. I love how we are refactoring these docs. They will become an example for all other WGs.

/lgtm

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Copy link
Member Author

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone for your review!
Let's merge this.
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 9903837 into kubeflow:master May 8, 2024
6 checks passed
@andreyvelich andreyvelich deleted the katib-improve-docs branch May 8, 2024 18:49

# Refactor Katib docs
/docs/components/hyperparameter /docs/components/katib/overview
/docs/components/katib/hyperparameter /docs/components/katib/getting-started.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich this leads to a 404, because you have put /docs/components/katib/getting-started.md (with .md)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I fixed it: #3733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Improvements for Katib 0.17
5 participants