Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katib: Fix getting started example #3770

Merged

Conversation

andreyvelich
Copy link
Member

I fixed the Katib getting started example.

Also, I added the command to install SDK from the master branch and from the commit.

/assign @tenzen-y @johnugeorge @helenxie-bit

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Copy link

@andreyvelich: GitHub didn't allow me to assign the following users: helenxie-bit.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

I fixed the Katib getting started example.

Also, I added the command to install SDK from the master branch and from the commit.

/assign @tenzen-y @johnugeorge @helenxie-bit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jun 18, 2024
@andreyvelich
Copy link
Member Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 05d62d2 into kubeflow:master Jun 18, 2024
6 checks passed
@andreyvelich andreyvelich deleted the katib-fix-getting-started branch June 18, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants