Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Set timeout for cloud build and upgrade goland version #70

Merged
merged 1 commit into from
May 14, 2020

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented May 14, 2020

This is to solve the build failure in #69
Kubernetes 1.15 has more staging folder and build is slower than 1.12. We need to set timeout explicitly.

  1. gcloud build submit by default has 10m timeout. If dependency is large or overlay is slow, it’s possible build timeout. Create a new argument with default 30m timeout

  2. Remove vendor copy since it’s build on top of go modules

  3. Upgrade Dockerfile golang version to match version in go.mod

Signed-off-by: Jiaxin Shan seedjeffwan@gmail.com

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
Copy link
Member

Thanks!

1. `gcloud build submit` by default has 10m timeout. If dependency is large or overlay is slow, it’s possible build timeout. Create a new argument with default 30m timeout

2. Remove vendor copy since it’s build on top of go modules

3. Upgrade Dockerfile golang version to match version in go.mod

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
@terrytangyuan
Copy link
Member

/lgtm

@Jeffwan
Copy link
Member Author

Jeffwan commented May 14, 2020

CI commands:

/bin/bash -c /mnt/test-data-volume/kubeflow-xgboost-operator-presubmit-build-70-9aa764f-7905-1ef1/src/kubeflow/xgboost-operator//build_image.sh 
/mnt/test-data-volume/kubeflow-xgboost-operator-presubmit-build-70-9aa764f-7905-1ef1/src/kubeflow/xgboost-operator//Dockerfile 
gcr.io/kubeflow-ci/xgboost-operator v1.0

while build_image.sh uses
https://github.com/kubeflow/xgboost-operator/blob/master/build_image.sh#L10-L12

v1.0 is not consumed and that makes the test failure. I change timeout to default 30m for now.

@k8s-ci-robot k8s-ci-robot merged commit 78f8cf5 into kubeflow:master May 14, 2020
@Jeffwan Jeffwan deleted the build_cleanup branch May 14, 2020 00:50
xfate123 pushed a commit to xfate123/xgboost-operator that referenced this pull request May 16, 2020
1. `gcloud build submit` by default has 10m timeout. If dependency is large or overlay is slow, it’s possible build timeout. Create a new argument with default 30m timeout

2. Remove vendor copy since it’s build on top of go modules

3. Upgrade Dockerfile golang version to match version in go.mod

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants