This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Set timeout for cloud build and upgrade goland version #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrytangyuan
approved these changes
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! |
1. `gcloud build submit` by default has 10m timeout. If dependency is large or overlay is slow, it’s possible build timeout. Create a new argument with default 30m timeout 2. Remove vendor copy since it’s build on top of go modules 3. Upgrade Dockerfile golang version to match version in go.mod Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
/lgtm |
CI commands:
while
|
xfate123
pushed a commit
to xfate123/xgboost-operator
that referenced
this pull request
May 16, 2020
1. `gcloud build submit` by default has 10m timeout. If dependency is large or overlay is slow, it’s possible build timeout. Create a new argument with default 30m timeout 2. Remove vendor copy since it’s build on top of go modules 3. Upgrade Dockerfile golang version to match version in go.mod Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to solve the build failure in #69
Kubernetes 1.15 has more staging folder and build is slower than 1.12. We need to set timeout explicitly.
gcloud build submit
by default has 10m timeout. If dependency is large or overlay is slow, it’s possible build timeout. Create a new argument with default 30m timeoutRemove vendor copy since it’s build on top of go modules
Upgrade Dockerfile golang version to match version in go.mod
Signed-off-by: Jiaxin Shan seedjeffwan@gmail.com