Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Gitlab's full_path instead of name while using authentication by Groups #181

Closed
gopigrip7 opened this issue Jul 13, 2018 · 4 comments
Closed

Using Gitlab's full_path instead of name while using authentication by Groups #181

gopigrip7 opened this issue Jul 13, 2018 · 4 comments

Comments

@gopigrip7
Copy link

Hi,
Thanks for the guard. I had integrated with our on-premises gitlab and working great. One requirement that would help us is authentication using group/subgroup. While checking code, guard uses group name instead if its use full_path; then we can grant access subgroup level.

Thanks
Gopinath
@tamalsaha
Copy link
Contributor

tamalsaha commented Jul 14, 2018 •
edited

Thanks for trying Guard, @gopigrip7. Sounds good to me, do you want to send a pr?

@tamalsaha
Copy link
Contributor

cc: @nightfury1204

@elthariel
Copy link

Also, group name isn't necessarily unique

tamalsaha added a commit that referenced this issue Dec 3, 2018
@tamalsaha
Support group id or full_path for Gitlab connector
3f19b0d 
Fixes #181

Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha added a commit that referenced this issue Dec 3, 2018
@tamalsaha
Support group id or full_path for Gitlab connector
575aab1 
Fixes #181

Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha tamalsaha mentioned this issue Dec 3, 2018
Merged
tamalsaha added a commit that referenced this issue Dec 3, 2018
@tamalsaha
Support group id or full_path for Gitlab connector (#201)
9cbc2b6 
Fixes #181

Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha tamalsaha mentioned this issue Dec 3, 2018
Merged
@tamalsaha
Copy link
Contributor

Fixed in https://github.com/appscode/guard/releases/tag/0.3.0

@nightfury1204 nightfury1204 mentioned this issue Jul 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tamalsaha @elthariel @gopigrip7