Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github connector docs asks for unnecessary public_repo permissions #195

Closed
tmatias opened this issue Nov 14, 2018 · 1 comment
Closed

Github connector docs asks for unnecessary public_repo permissions #195

tmatias opened this issue Nov 14, 2018 · 1 comment

Comments

@tmatias
Copy link
Contributor

tmatias commented Nov 14, 2018

The documentation on the Github connector says

To use Github authentication, you can use your personal access token with permissions to read public_repo and read:org

Looking at the connector's source, though, it doesn't seem to use it.

public_repo, despite its name, grants a somewhat broad set of permissions, so it would be nice not to require it.

I tried guard with a read:org only token as well, and couldn't see any problems either.
@tmatias tmatias changed the title Github connector docs ask for unnecessary public_repo permissions Github connector docs asks for unnecessary public_repo permissions Nov 14, 2018
tamalsaha added a commit that referenced this issue Dec 3, 2018
@tamalsaha
Document Github connector permissions to read:org
df86e0d 
Fixes #195

Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha tamalsaha mentioned this issue Dec 3, 2018
Merged
tamalsaha added a commit that referenced this issue Dec 3, 2018
@tamalsaha
Document Github connector permissions to read:org (#200)
72d38a6 
Fixes #195

Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha
Copy link
Contributor

Fixed in https://github.com/appscode/guard/releases/tag/0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tamalsaha @tmatias