Add option to verify client ID #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
forced push to update doc. @karataliu PTAL |
karataliu
reviewed
Feb 11, 2020
Signed-off-by: Weinong Wang <weinong@outlook.com>
karataliu
approved these changes
Feb 11, 2020
|
@tamalsaha PTAL |
tamalsaha
approved these changes
Feb 13, 2020
tamalsaha
changed the title
|
@weinong , do you plan to open any more pr regarding this or should I cut a release? |
|
@tamalsaha you can cut the release. The only thing left on my todo is to add metrics. But that will come later. Thank you! |
nightfury1204
pushed a commit
to nightfury1204/guard
that referenced
this pull request
Jul 3, 2020
Add an option in azure auth module to verify client ID which follows the best practice from Azure AD It fixes kubeguard#244 Signed-off-by: Weinong Wang <weinong@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option in azure auth module to verify client ID which follows the best practice from Azure AD
It fixes #244