Reorg codebase #82
Merged
Reorg codebase #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamalsaha
force-pushed
the
prom
branch
4 times, most recently
from
9a1fc57
to
a8c0e6a
Compare
nightfury1204
previously approved these changes
Mar 12, 2018
azure/azure.go
Outdated
| } | ||
| review.Status.User.Username = username | ||
| resp.Username = username | ||
|
|
||
| //groups contain group-id | ||
| groups, err := c.StringSlice(groupsClaim) |
There was a problem hiding this comment.
groups claim not required, because we use ms graph client to get user's groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
Fixes #14