Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs regarding authentication #269

Merged
merged 2 commits into from Dec 2, 2020
Merged

Fix bugs regarding authentication #269

merged 2 commits into from Dec 2, 2020

Commits on Dec 1, 2020

  1. Fix authentication screen for larger screens 

    For larger screens (tablets), the Sign In button was hidden and the user
had to scroll to click the button. Now the button should be visible for
all display sizes.

For that we add a new hook useWindowHeight, which returns the current
height of the window. If the window height is to small to display the
icon and the Sign In button we hide the icon.

We also rename the Sign In button to Unlock.
    @ricoberger
    ricoberger committed Dec 1, 2020
    Copy the full SHA
    27180f9 View commit details
    Browse the repository at this point in the history

  2. Ask for unlock without clicking the unlock button 

    Instead of clicking the unlock button, the user is automatically ask to
unlock the app via Face ID / Touch ID. This means the user only must
click the unlock button, when the authentication fails.
    @ricoberger
    ricoberger committed Dec 1, 2020
    Copy the full SHA
    bac3841 View commit details
    Browse the repository at this point in the history