Add Support for Streaming Logs #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to listen on a stream of logs for a Pod / Container. For this we had added a new route to the http server, which can be used to create a WebSocket connection to stream the logs. We have keept the original logs implementation, because when the user just wants to see the logs without following them we can still use this implementation, which has the advantage that we do not have to start a http server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to listen on a stream of logs for a Pod / Container. For this we had added a new route to the http server, which can be used to create a WebSocket connection to stream the logs.
We have keept the original logs implementation, because when the user just wants to see the logs without following them we can still use this implementation, which has the advantage that we do not have to start a http server.