Add support to stream logs #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new options to the logs popover to stream log files. If the streaming option is selected a request is made to generate a session id. This session id can be used to retrieve the logs via Server Sent Events. Unlike the other options, the stream logs option uses xterm to show the logs (for the other options we use Ace), because the editor would be rerendered when retrieving a log line.
|
Hello @ricoberger, has this been removed from the latest? It seems that I can only get the last 5 minutes now |
|
Hi @balthazar, thanks for the hint. Yes this was accidentally removed, I will re-add it. |
|
Hi @balthazar, this should be available again in the next version. See #482 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new options to the logs popover to stream log files. If the streaming option is selected a request is made to generate a session id. This session id can be used to retrieve the logs via Server Sent Events.
Unlike the other options, the stream logs option uses xterm to show the logs (for the other options we use Ace), because the editor would be rendered when retrieving a log line.
{ "server": "http://localhost:14122", "cluster": "<CONTEXT>", "method": "GET", "url": "https://<SERVER>/api/v1/namespaces/vault-secrets-operator/pods/vault-secrets-operator-54747b55df-697ct/log?container=vault-secrets-operator&follow=true&tailLines=10", "timeout": 60 }Closes #60.