Add "Classic Mode" #493
Merged
Add "Classic Mode" #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new "classic mode" implements the design of version 3 of kubenav, which is prefered by some users. Since the required changes and the maintance effort shouldn't be that high we can support the new design and the old one as opt in. The changes which are applied, when a user opt in for the "classic mode" are the followings: - Remove the bottom navigation bar and add a sidebar for the navigation in the app - Remove the resource actions header (the one were a user can view the logs of a container or scale a deployment) and move the actions to a menu, which can be accessed via the app bar. See #477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new "classic mode" implements the design of version 3 of kubenav, which is prefered by some users. Since the required changes and the maintance effort shouldn't be that high we can support the new design and the old one as opt in. The changes which are applied, when a user opt in for the "classic mode" are the followings:
See #477