Fix Unnecessary Rerenderings when Using Bookmark Action #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user bookmarked a list of resources or a single resource in the details view, the whole page was rerendered, because we have to listen for updates on the `BookmarksRepository`. To avoid that the whole view is rerendered we moved the actions to a seperate widget and only listen there for changes of the `BookmarksRepository`. We also changed the `additionalActions` property, to not except a list of actions, but only a `refresh` function, which can be defined in the details view and which can be `null` in the list view.
ricoberger
deleted the
fix-unnecessary-rerenderings-when-using-bookmark-action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user bookmarked a list of resources or a single resource in the details view, the whole page was rerendered, because we have to listen for updates on the
BookmarksRepository. To avoid that the whole view is rerendered we moved the actions to a seperate widget and only listen there for changes of theBookmarksRepository.We also changed the
additionalActionsproperty, to not except a list of actions, but only arefreshfunction, which can be defined in the details view and which can benullin the list view.