Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the goreleaser architecture for arm and ppc #824

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix the goreleaser architecture for arm and ppc #824

merged 1 commit into from
Sep 12, 2023

Conversation

grisu48
Copy link
Contributor

@grisu48 grisu48 commented Aug 31, 2023 •
edited

Replace aarch64, ppc64le arm armv7l with matching architectures for the goreleaser.

Proposed solution for #823

@grisu48 grisu48 mentioned this pull request Aug 31, 2023
Merged
ckotzbauer
ckotzbauer previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@ckotzbauer ckotzbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks:)

@grisu48
Copy link
Contributor Author

grisu48 commented Sep 1, 2023

Updated the PR and made shellcheck happy 🙂

@dirkmueller
Copy link

ping :)

@grisu48 grisu48 mentioned this pull request Sep 5, 2023
Merged
@grisu48
Copy link
Contributor Author

grisu48 commented Sep 6, 2023 •
edited

Test run on an aarch64 VM: build.txt

make bootstrap-tools kured && go test -race ./... && go build ./...

I get a binary in dist/kured_linux_arm64 that works, judging from ./kured -h

@grisu48
Copy link
Contributor Author

grisu48 commented Sep 7, 2023

PR amended and tested on aarch64.

@grisu48 grisu48 changed the title Fix the goreleaser architecture for aarch64 Fix the goreleaser architecture for arm and ppc Sep 7, 2023
@ckotzbauer
Copy link
Member

@grisu48 Unfortunately the shellcheck is still not happy.

@grisu48
Fix the goreleaser architecture for arm and ppc
a4f368e 
Replace aarch64, ppc64le arm armv7l with matching architectures for the
goreleaser.

Signed-off-by: phoenix <felix.niederwanger@suse.com>
@grisu48
Copy link
Contributor Author

grisu48 commented Sep 12, 2023

PR amended and tested on aarch64.

@ckotzbauer ckotzbauer merged commit 48981e6 into kubereboot:main Sep 12, 2023
14 checks passed
@grisu48 grisu48 deleted the aarch64 branch September 14, 2023 11:09
@grisu48
Copy link
Contributor Author

grisu48 commented Sep 14, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmueller dirkmueller dirkmueller left review comments

@dholbach dholbach dholbach left review comments

@ckotzbauer ckotzbauer ckotzbauer left review comments

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grisu48 @dirkmueller @ckotzbauer @dholbach