HELM add variabels for runInterval & timeout #424
Conversation
Want to be able to disable this function during e2e tests
| @@ -1,3 +1,5 @@ | |||
| {{- if .Values.checkReaper.enabled }} | |||
There was a problem hiding this comment.
I'm hesitant to make check-reaper configurable in helm... Only concern being that if folks are using Kuberhealthy 2.1.0+, checks will not get cleaned up. If we were to make it configurable in Helm, it would be definitely have to be enabled by default and customers should be warned about disabling it
deploy/helm/kuberhealthy/values.yaml
Outdated
| image: | ||
| repository: kuberhealthy/pod-status-check | ||
| tag: v1.2.2 | ||
| extraEnvs: | ||
| nodeSelector: {} | ||
|
|
||
| checkReaper: | ||
| enabled: true |
There was a problem hiding this comment.
Mentioned already in the above comment, but a warning would be nice here if this is disabled! Also wondering if this should be contingent on what Kuberhealthy version they're using. I say that if they're using Kuberhealthy 2.1.0+, this should be enabled!
|
thanks for addressing your own issue :) added a comment about the @jonnydawg @chadbitzer, i know you guys did most of the helm configurations, so would be nice to get your reviews! |
This to enable people to know about the feature. Forgot to do it in: kuberhealthy#361
|
No worries. I added a extra varning in the values file as you pointed out @joshulyne. |
Will put in a seperate PR instead so I also update the rest of the deployment files.
| podSpec: | ||
| containers: | ||
| - name: deployment | ||
| image: {{ .Values.check.deployment.image.repository }}:{{ .Values.check.deployment.image.tag }} | ||
| imagePullPolicy: IfNotPresent | ||
| env: | ||
| - name: CHECK_TIME_LIMIT | ||
| value: *deployment_check_timeout | ||
| value: {{ .Values.check.deployment.timeout }} |
There was a problem hiding this comment.
Thanks! I was wondering if there was a better way to do this (yaml anchors and nodes) -- it seems like helm is a perfect solution!
Fixing #422 also added the possibility to enable & disable checkReaper, I think this will be nice when doing e2e tests.