Gosec

[jonnydawg]

Implements a github workflow to run gosec on external checks for PRs against master

[jonnydawg]

https://github.com/Comcast/kuberhealthy/runs/637224151?check_suite_focus=true

Currently, here are the issues found:

[/home/runner/work/kuberhealthy/kuberhealthy/cmd/deployment-check/input.go:78] - G109 (CWE-190): Potential Integer overflow made by strconv.Atoi result conversion to int16/32 (Confidence: MEDIUM, Severity: HIGH)
  > port, err := strconv.Atoi(checkContainerPortEnv)

[/home/runner/work/kuberhealthy/kuberhealthy/cmd/deployment-check/input.go:89] - G109 (CWE-190): Potential Integer overflow made by strconv.Atoi result conversion to int16/32 (Confidence: MEDIUM, Severity: HIGH)
  > port, err := strconv.Atoi(checkLoadBalancerPortEnv)

[/home/runner/work/kuberhealthy/kuberhealthy/cmd/daemonset-check/main.go:304] - G104 (CWE-703): Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > dsc.remove()

[/home/runner/work/kuberhealthy/kuberhealthy/cmd/deployment-check/run_check.go:235] - G104 (CWE-703): Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > cleanUp(ctx)

[/home/runner/work/kuberhealthy/kuberhealthy/cmd/deployment-check/service_requester.go:141] - G104 (CWE-703): Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > resp.Body.Close()

[/home/runner/work/kuberhealthy/kuberhealthy/cmd/deployment-check/service_requester.go:153] - G104 (CWE-703): Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > resp.Body.Close()

[/home/runner/work/kuberhealthy/kuberhealthy/cmd/http-check/main.go:49] - G104 (CWE-703): Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > kh.ReportSuccess()

[/home/runner/work/kuberhealthy/kuberhealthy/cmd/http-check/main.go:55] - G104 (CWE-703): Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > kh.ReportFailure([]string{reportErr.Error()})

[/home/runner/work/kuberhealthy/kuberhealthy/cmd/resource-quota-check/main.go:87] - G104 (CWE-703): Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > kh.ReportFailure([]string{errorMessage})

[/home/runner/work/kuberhealthy/kuberhealthy/cmd/resource-quota-check/main.go:98] - G104 (CWE-703): Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > kh.ReportFailure([]string{r.(string)})

Summary:
   Files: 48
   Lines: 8115
   Nosec: 0
  Issues: 10

##[error]Process completed with exit code 1.

[jonnydawg]

I also think we should remove the gosec layer from the dockerfile from cmd/kuberhealthy and do it via a github action instead.

[integrii]

This is great upkeep. Thanks!

[integrii]

#458